Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jaeger-thrift-splunk trace exporter #2690

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

pellared
Copy link
Contributor

Fixes #2688

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6361675) 82.43% compared to head (31facf4) 82.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2690      +/-   ##
==========================================
- Coverage   82.43%   82.14%   -0.30%     
==========================================
  Files          83       83              
  Lines        3246     3248       +2     
==========================================
- Hits         2676     2668       -8     
- Misses        497      505       +8     
- Partials       73       75       +2     
Flag Coverage Δ
Linux 82.14% <100.00%> (+0.01%) ⬆️
Windows ?
macOS 77.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared marked this pull request as ready for review December 18, 2023 12:40
@pellared pellared requested review from a team as code owners December 18, 2023 12:40
Copy link

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

@pellared pellared merged commit 0ee17a2 into signalfx:main Dec 18, 2023
15 checks passed
@pellared pellared deleted the deprecate-jaeger branch December 18, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate jaeger-thrift-splunk option for OTEL_TRACES_EXPORTER
4 participants