Skip to content

Commit

Permalink
re-commit @t2t2's changes b/c we lost the signature
Browse files Browse the repository at this point in the history
  • Loading branch information
sfishel-splunk committed Jul 8, 2022
1 parent e0b66e2 commit 4307c2a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion integration-tests/tests/cdn/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ module.exports = {
}

const rumScriptFetchSpan = await browser.globals.findSpan(
(s) => s.name === 'resourceFetch'
(s) => s.name === 'resourceFetch' && s.tags['http.url'].includes('cdn.signalfx.com')
);
await browser.assert.ok(
!!rumScriptFetchSpan,
Expand Down
20 changes: 10 additions & 10 deletions integration-tests/tests/errors/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ module.exports = {
await browser.assert.strictEqual(tags['error.message'], ERROR_MESSAGE_MAP[browserName]);

const ERROR_STACK_MAP = {
safari: `global code@${url}:61:15`,
chrome: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:61:25`,
microsoftedge: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:61:25`,
firefox: `@${url}:61:7\n`,
'internet explorer': `TypeError: Unable to set property 'anyField' of undefined or null reference\n at Global code (${url}:61:7)`,
safari: `global code@${url}:62:15`,
chrome: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:62:25`,
microsoftedge: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:62:25`,
firefox: `@${url}:62:7\n`,
'internet explorer': `TypeError: Unable to set property 'anyField' of undefined or null reference\n at Global code (${url}:62:7)`,
};
await browser.assert.strictEqual(tags['error.stack'], ERROR_STACK_MAP[browserName]);
},
Expand Down Expand Up @@ -156,11 +156,11 @@ module.exports = {
await browser.assert.strictEqual(tags['error.message'], ERROR_MESSAGE_MAP[browserName]);

const ERROR_STACK_MAP = {
safari: `global code@${url}:61:15`,
microsoftedge: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:61:25`,
chrome: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:61:25`,
firefox: `@${url}:61:7\n`,
'internet explorer': `TypeError: Unable to set property 'anyField' of undefined or null reference\n at Global code (${url}:61:7)`,
safari: `global code@${url}:62:15`,
microsoftedge: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:62:25`,
chrome: `TypeError: Cannot set properties of null (setting 'anyField')\n at ${url}:62:25`,
firefox: `@${url}:62:7\n`,
'internet explorer': `TypeError: Unable to set property 'anyField' of undefined or null reference\n at Global code (${url}:62:7)`,
};
await browser.assert.strictEqual(tags['error.stack'], ERROR_STACK_MAP[browserName]);
},
Expand Down

0 comments on commit 4307c2a

Please sign in to comment.