Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod_avmd] exposing more parameters to config #2418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[mod_avmd] exposing more parameters to config #2418

wants to merge 1 commit into from
+132 −8

Conversation

evgeniibuchnev
Copy link

  1. Exposing previously hardcoded parameters in mod_avmd.c to be configurable, this would allow fine-tuning mod_avmd to suite wider needs.
  • AVMD_MIN_FREQUENCY
  • AVMD_MAX_FREQUENCY
  • AVMD_MIN_AMP
  • AVMD_VARIANCE_RSD_THRESHOLD
  • AVMD_AMPLITUDE_RSD_THRESHOLD
  1. Updated default avmd.conf.xml to have default values for new exposed parameters.

[mod_avmd] exposing more parameters to config
da529bb 
1. Exposing previously hardcoded parameters in mod_avmd.c to be configurable, this would allow fine-tuning mod_avmd to suite wider needs.

- AVMD_MIN_FREQUENCY
- AVMD_MAX_FREQUENCY
- AVMD_MIN_AMP
- AVMD_VARIANCE_RSD_THRESHOLD
- AVMD_AMPLITUDE_RSD_THRESHOLD

2. Updated default avmd.conf.xml to have default values for new exposed parameters.
@signalwire-ci
Copy link

signalwire-ci bot commented Apr 3, 2024

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1703/artifacts.html

@evgeniibuchnev
Copy link
Author

Hey Team,
Tried to be proactive with my pull request - I had a look into FAILed tests and they seem to me not related to the changes on mod_avmd, wondering if you could have a look into failed tests.
These reported failing:

  • FST_TEST_BEGIN(register_ok)
  • FST_TEST_BEGIN(uac_digest_leak_tcp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@evgeniibuchnev