Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-11587: Fixed hardcoded uuid length in msrp_find_uuid function #5

Closed
wants to merge 1 commit into from

Conversation

sergey-safarov
Copy link
Contributor

No description provided.

@mjerris
Copy link
Collaborator

mjerris commented Sep 25, 2019

can you provide reference in spec to what uuid should be please

@sergey-safarov
Copy link
Contributor Author

Are you want reference to uuid length?
My use case is kazoo installations.
Kazoo defines own ID in dialplan and later MSRP messages cannot be route because length of custom uuid and default is different.

@mjerris
Copy link
Collaborator

mjerris commented Sep 25, 2019

looking to confirm in msrp spec if you can have different length uuid or not

@sergey-safarov
Copy link
Contributor Author

please check RFC4975
Here

To-Path: msrp://biloxi.example.com:12763/kjhd37s2s20w2a;tcp

UUID here "kjhd37s2s20w2a" shorted then 36 char sting.

@mjerris
Copy link
Collaborator

mjerris commented Sep 25, 2019

ok so that looks good. Please add a unit test for this.

@sergey-safarov
Copy link
Contributor Author

I cannot create test unit.

@mjerris
Copy link
Collaborator

mjerris commented Sep 25, 2019

please re-open when you are able to add a unit test for this.

@mjerris mjerris closed this Sep 25, 2019
@mjerris
Copy link
Collaborator

mjerris commented Sep 25, 2019

This was referenced Oct 11, 2019
@anshkatriya anshkatriya mentioned this pull request Nov 27, 2019
@sergey-safarov sergey-safarov deleted the FS-11587 branch December 12, 2019 03:34
mjerris pushed a commit that referenced this pull request Jan 9, 2020
[mod_local_stream] Xml object is leaked on reload when cannot stop local_stream beeing in use.
@nwaycn nwaycn mentioned this pull request Mar 28, 2020
@mjerris mjerris mentioned this pull request Aug 21, 2020
@fx02 fx02 mentioned this pull request Jun 9, 2021
@admin-toneca admin-toneca mentioned this pull request Apr 8, 2022
@xxmcf xxmcf mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants