Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build-System] Relocate modules deps in freeswitch.spec #6

Merged
merged 1 commit into from Aug 18, 2020

Conversation

sergey-safarov
Copy link
Contributor

FS core not use this deps

@andywolk andywolk self-assigned this Sep 25, 2019
@andywolk andywolk added the enhancement New feature or request label Sep 25, 2019
This was referenced Oct 11, 2019
@anshkatriya anshkatriya mentioned this pull request Nov 27, 2019
@sergey-safarov sergey-safarov deleted the specUP4 branch December 12, 2019 03:34
mjerris pushed a commit that referenced this pull request Jan 9, 2020
[mod_voicemail] vm_fsdb_msg_email command leaks xml object.
@nwaycn nwaycn mentioned this pull request Mar 28, 2020
@sergey-safarov sergey-safarov restored the specUP4 branch May 1, 2020 07:47
@sergey-safarov sergey-safarov reopened this May 1, 2020
evanowen pushed a commit to inteliquent/freeswitch-1 that referenced this pull request May 5, 2020
Copy link
Collaborator

@s3rj1k s3rj1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-safarov Hi, thanks for PR, can you please clarify why do you remove BuildRequires: net-snmp-devel?

@sergey-safarov
Copy link
Contributor Author

@s3rj1k
this because net-snmp-devel need only for mod_snmp and this deps already present in event-snmp package.
https://github.com/signalwire/freeswitch/blob/master/freeswitch.spec#L1114

@s3rj1k
Copy link
Collaborator

s3rj1k commented Aug 13, 2020

@sergey-safarov I see, missed that, looks good, thanks.

@s3rj1k s3rj1k self-requested a review August 13, 2020 18:14
Copy link
Collaborator

@s3rj1k s3rj1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andywolk andywolk changed the title FS-11567: freeswitch.spec - relocated modules deps [Build-System] Relocated modules deps in freeswitch.spec Aug 17, 2020
@andywolk andywolk changed the title [Build-System] Relocated modules deps in freeswitch.spec [Build-System] Relocate modules deps in freeswitch.spec Aug 17, 2020
@fx02 fx02 mentioned this pull request Jun 9, 2021
@admin-toneca admin-toneca mentioned this pull request Apr 8, 2022
@xxmcf xxmcf mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants