Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] UI indicates whether your query filter uses a Tag or Resource attribute #5359

Open
atmask opened this issue Jun 26, 2024 · 2 comments
Open
Assignees

Comments

@atmask
Copy link

atmask commented Jun 26, 2024

Seomtimes there are valid uses cases where a resource attribute and a tag attribute have the same name. It took a long time to realize that the query bar for logs wasn't respecting the selected type between tag and resource (related issue: #5150). To discover this I had to dig into the network tab on chrome and find the query.

The UI should have a visual indication that let's user's know whether their query filter key is using a tag or resource. This could be as simply as T or R icon

image

@nityanandagohain
Copy link
Member

@GeekBoySupreme please let us know your thoughts on this form design point of view.

@GeekBoySupreme
Copy link
Collaborator

I think you'd have the icon on the suggestion dropdown too for it to be relevant/useful. And you can also colour code the T and R - so the pill can be of some colour for tag attribute and something else for resource attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants