fix: windows build error + navigate by 2 #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if either of these are Windows specific so let me know if they (don't) work for you on other platforms.
Build Error
Running
cargo install
or justbuild
results in the following:Not sure how this is not a problem in other platforms but it works for me now.
Navigating by 2
Using the up and down arrow keys causes the menu selection to move twice. This is because key events are fired both on press down and on release. I am again confused about how this was not noticed before which leads me to believe some weird platform-specific business is going on in here perhaps?
In any case, this likely affects other parts of the relevant match case, I didn't make any edits as I won't be using any of the other keys and I don't know if this is just a me problem or not. Let me know if you want me to look into them as well for the sake of the PR.