Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation BLS verification is bypassed #3

Closed
paulhauner opened this issue Jul 16, 2018 · 1 comment
Closed

Attestation BLS verification is bypassed #3

paulhauner opened this issue Jul 16, 2018 · 1 comment

Comments

@paulhauner
Copy link
Member

paulhauner commented Jul 16, 2018

https://github.com/sigp/rust_beacon_chain/blob/6f0bbd47fac20652472c1ff5799aac367af5d929/src/state/transition/attestations.rs#L30-L37

This is blocked by #1.

@paulhauner
Copy link
Member Author

No longer relevant -- v2.1 spec requires a full re-write

lightclient pushed a commit to lightclient/lighthouse that referenced this issue Sep 25, 2019
bors bot pushed a commit that referenced this issue May 12, 2022
Perform v9 migration less-atomically
AgeManning referenced this issue in AgeManning/lighthouse Feb 22, 2023
Fix closure lifetimes by using functions
bors bot pushed a commit that referenced this issue May 17, 2023
Workaround format_args! with closure
paulhauner added a commit that referenced this issue May 19, 2023
Squashed commit of the following:

commit 16771dc
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:27:47 2023 +1000

    fmt

commit 1deeafe
Merge: 9f5ca3d b29bb2e
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:26:13 2023 +1000

    Merge latest unstable

commit 9f5ca3d
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:24:06 2023 +1000

    Enable SSE logs only on GUI flag and misc reviewers comments

commit 5eeca70
Merge: 3efdbe2 d64be0d
Author: Age Manning <Age@AgeManning.com>
Date:   Tue May 9 10:08:05 2023 +1000

    Merge latest unstable

commit 3efdbe2
Author: Age Manning <Age@AgeManning.com>
Date:   Mon May 8 17:13:12 2023 +1000

    fmt

commit 202aad8
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 16:30:19 2023 +1000

    Remove api token requirement for sse logs

commit 5411d5a
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 15:57:59 2023 +1000

    Remove double json encoding

commit 29fb985
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:32:31 2023 +1000

    fmt

commit 3e10b26
Merge: 37ec9b7 826e748
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:30:41 2023 +1000

    Merge latest unstable

commit 37ec9b7
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 16:25:45 2023 +1100

    Revert old clippy change

commit b3d0167
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:45:31 2023 +1100

    Appease clippy

commit 1df3191
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:08:28 2023 +1100

    Fix tests

commit fc7645e
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 13:43:52 2023 +1100

    Fix logging tests via tokio upgrade

commit 4988a15
Merge: 6cf9338 90cef1d
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:47:26 2023 +1100

    Merge latest unstable

commit 6cf9338
Merge: 5deabe0 3ad77fb
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:51 2023 +1100

    Merge latest unstable

commit 5deabe0
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:45 2023 +1100

    fmt

commit 5f24f65
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:38:36 2023 +1100

    A working version

commit 4da3351
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:44:22 2023 +1100

    Tokio broadcast version

commit e34aab2
Merge: cd6edbc 9d821ce
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:17:38 2023 +1100

    Merge pull request #3 from michaelsproul/sse-logs

    Workaround format_args! with closure

commit 9d821ce
Author: Michael Sproul <micsproul@gmail.com>
Date:   Thu Mar 9 11:57:51 2023 +1100

    Workaround format_args! with closure

commit cd6edbc
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 11:18:02 2023 +1100

    Getting closer

commit e9eb455
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 8 16:38:58 2023 +1100

    Crossbeam version

commit b688cfb
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 7 14:56:17 2023 +1100

    More temp commits

commit 228b930
Merge: 035ca37 17d9a62
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 1 13:05:45 2023 +1100

    Merge latest unstable

commit 035ca37
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Feb 8 20:24:39 2023 +1100

    Temp progress
paulhauner added a commit that referenced this issue May 20, 2023
Squashed commit of the following:

commit 16771dc
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:27:47 2023 +1000

    fmt

commit 1deeafe
Merge: 9f5ca3d b29bb2e
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:26:13 2023 +1000

    Merge latest unstable

commit 9f5ca3d
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:24:06 2023 +1000

    Enable SSE logs only on GUI flag and misc reviewers comments

commit 5eeca70
Merge: 3efdbe2 d64be0d
Author: Age Manning <Age@AgeManning.com>
Date:   Tue May 9 10:08:05 2023 +1000

    Merge latest unstable

commit 3efdbe2
Author: Age Manning <Age@AgeManning.com>
Date:   Mon May 8 17:13:12 2023 +1000

    fmt

commit 202aad8
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 16:30:19 2023 +1000

    Remove api token requirement for sse logs

commit 5411d5a
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 15:57:59 2023 +1000

    Remove double json encoding

commit 29fb985
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:32:31 2023 +1000

    fmt

commit 3e10b26
Merge: 37ec9b7 826e748
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:30:41 2023 +1000

    Merge latest unstable

commit 37ec9b7
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 16:25:45 2023 +1100

    Revert old clippy change

commit b3d0167
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:45:31 2023 +1100

    Appease clippy

commit 1df3191
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:08:28 2023 +1100

    Fix tests

commit fc7645e
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 13:43:52 2023 +1100

    Fix logging tests via tokio upgrade

commit 4988a15
Merge: 6cf9338 90cef1d
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:47:26 2023 +1100

    Merge latest unstable

commit 6cf9338
Merge: 5deabe0 3ad77fb
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:51 2023 +1100

    Merge latest unstable

commit 5deabe0
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:45 2023 +1100

    fmt

commit 5f24f65
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:38:36 2023 +1100

    A working version

commit 4da3351
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:44:22 2023 +1100

    Tokio broadcast version

commit e34aab2
Merge: cd6edbc 9d821ce
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:17:38 2023 +1100

    Merge pull request #3 from michaelsproul/sse-logs

    Workaround format_args! with closure

commit 9d821ce
Author: Michael Sproul <micsproul@gmail.com>
Date:   Thu Mar 9 11:57:51 2023 +1100

    Workaround format_args! with closure

commit cd6edbc
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 11:18:02 2023 +1100

    Getting closer

commit e9eb455
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 8 16:38:58 2023 +1100

    Crossbeam version

commit b688cfb
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 7 14:56:17 2023 +1100

    More temp commits

commit 228b930
Merge: 035ca37 17d9a62
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 1 13:05:45 2023 +1100

    Merge latest unstable

commit 035ca37
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Feb 8 20:24:39 2023 +1100

    Temp progress
paulhauner added a commit that referenced this issue May 22, 2023
Squashed commit of the following:

commit 16771dc
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:27:47 2023 +1000

    fmt

commit 1deeafe
Merge: 9f5ca3d b29bb2e
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:26:13 2023 +1000

    Merge latest unstable

commit 9f5ca3d
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 17 15:24:06 2023 +1000

    Enable SSE logs only on GUI flag and misc reviewers comments

commit 5eeca70
Merge: 3efdbe2 d64be0d
Author: Age Manning <Age@AgeManning.com>
Date:   Tue May 9 10:08:05 2023 +1000

    Merge latest unstable

commit 3efdbe2
Author: Age Manning <Age@AgeManning.com>
Date:   Mon May 8 17:13:12 2023 +1000

    fmt

commit 202aad8
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 16:30:19 2023 +1000

    Remove api token requirement for sse logs

commit 5411d5a
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 15:57:59 2023 +1000

    Remove double json encoding

commit 29fb985
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:32:31 2023 +1000

    fmt

commit 3e10b26
Merge: 37ec9b7 826e748
Author: Age Manning <Age@AgeManning.com>
Date:   Wed May 3 14:30:41 2023 +1000

    Merge latest unstable

commit 37ec9b7
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 16:25:45 2023 +1100

    Revert old clippy change

commit b3d0167
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:45:31 2023 +1100

    Appease clippy

commit 1df3191
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 14:08:28 2023 +1100

    Fix tests

commit fc7645e
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 14 13:43:52 2023 +1100

    Fix logging tests via tokio upgrade

commit 4988a15
Merge: 6cf9338 90cef1d
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:47:26 2023 +1100

    Merge latest unstable

commit 6cf9338
Merge: 5deabe0 3ad77fb
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:51 2023 +1100

    Merge latest unstable

commit 5deabe0
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:39:45 2023 +1100

    fmt

commit 5f24f65
Author: Age Manning <Age@AgeManning.com>
Date:   Mon Mar 13 15:38:36 2023 +1100

    A working version

commit 4da3351
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:44:22 2023 +1100

    Tokio broadcast version

commit e34aab2
Merge: cd6edbc 9d821ce
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 13:17:38 2023 +1100

    Merge pull request #3 from michaelsproul/sse-logs

    Workaround format_args! with closure

commit 9d821ce
Author: Michael Sproul <micsproul@gmail.com>
Date:   Thu Mar 9 11:57:51 2023 +1100

    Workaround format_args! with closure

commit cd6edbc
Author: Age Manning <Age@AgeManning.com>
Date:   Thu Mar 9 11:18:02 2023 +1100

    Getting closer

commit e9eb455
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 8 16:38:58 2023 +1100

    Crossbeam version

commit b688cfb
Author: Age Manning <Age@AgeManning.com>
Date:   Tue Mar 7 14:56:17 2023 +1100

    More temp commits

commit 228b930
Merge: 035ca37 17d9a62
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Mar 1 13:05:45 2023 +1100

    Merge latest unstable

commit 035ca37
Author: Age Manning <Age@AgeManning.com>
Date:   Wed Feb 8 20:24:39 2023 +1100

    Temp progress
macladson referenced this issue in macladson/lighthouse Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant