Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore aggregate subsets on gossip #3238

Closed
AgeManning opened this issue Jun 3, 2022 · 1 comment
Closed

Ignore aggregate subsets on gossip #3238

AgeManning opened this issue Jun 3, 2022 · 1 comment
Assignees
@pawanjay176
Labels
Networking

Comments

@AgeManning
Copy link
Member

Description

We should implement: ethereum/consensus-specs#2847

This should help filter out duplicates and subset aggregate attestations.

We might need another error case for attestation and sync committee aggregate processing. Potentially @michaelsproul may be best suited for that modification.

We should also adjust the scoring parameters on these topics to account of the lower expected number of messages. Lodestar have indicated they see ~70-80% reduction in message count.
@pawanjay176 pawanjay176 self-assigned this Aug 17, 2022
@pawanjay176 pawanjay176 mentioned this issue Aug 23, 2022
Closed
bors bot pushed a commit that referenced this issue Jun 27, 2023
@pawanjay176
Aggregate subsets (#3493)
448d3ec 
## Issue Addressed

Resolves #3238 

## Proposed Changes

Please list or describe the changes introduced by this PR.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.
@pawanjay176
Copy link
Member

Completed in #3493

ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
@pawanjay176
Aggregate subsets (sigp#3493)
3ad2d07 
## Issue Addressed

Resolves sigp#3238 

## Proposed Changes

Please list or describe the changes introduced by this PR.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@pawanjay176 @Woodpile37
Aggregate subsets (sigp#3493)
32fbf9f 
Resolves sigp#3238

Please list or describe the changes introduced by this PR.

Please provide any additional information. For example, future considerations
or information useful for reviewers.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@pawanjay176 @Woodpile37
Aggregate subsets (sigp#3493)
ad52b6c 
Resolves sigp#3238

Please list or describe the changes introduced by this PR.

Please provide any additional information. For example, future considerations
or information useful for reviewers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanjay176 pawanjay176

Labels
Networking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AgeManning @pawanjay176 @divagant-martian