Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit contract finalization fails after checkpoint sync without deposit snapshot #3707

Open
michaelsproul opened this issue Nov 9, 2022 · 3 comments
Open

Deposit contract finalization fails after checkpoint sync without deposit snapshot #3707

michaelsproul opened this issue Nov 9, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@michaelsproul
Copy link
Member

Description

After checkpoint syncing my node from a public endpoint without deposit_snapshot support, I got an error log upon trying to finalize the cache:

Nov 07 03:22:02.324 WARN Remote BN does not support EIP-4881 fast deposit sync, service: beacon, module: client::builder:306
...
Nov 07 03:55:21.646 ERRO Failed to finalize deposit cache, error: FailedToFinalizeDeposit("Finalized block not found in block cache"), service: deposit_contract_rpc, module: eth1::service:754

I think this is because my node hadn't caught up to the finalized eth1 data. It recovered gracefully once it did, but I think it would be nice to avoid the ERRO log. We could just change it to a WARN if we think that it's too hard to differentiate the types of failure here. It should be quite infrequent anyway.

Version

v3.2.1 with #2915
@michaelsproul michaelsproul added bug Something isn't working v3.3.0 Minor release following v3.2.0 labels Nov 9, 2022
@michaelsproul
Copy link
Member Author

Full logs here: https://gist.github.com/michaelsproul/9171413dac5fbfa34b86953a00044319

cc @ethDreamer

@michaelsproul michaelsproul mentioned this issue Nov 21, 2022
Closed
bors bot pushed a commit that referenced this issue Nov 21, 2022
@michaelsproul
Lower deposit finalization error to warning (#3739)
b477c42 
## Issue Addressed

Partially addresses #3707

## Proposed Changes

Drop `ERRO` log to `WARN` until we identify the exact conditions that lead to this case.

Add a message which hopefully reassures users who only see this log once 😅 

Add the block hash to the error message in case it will prove useful in debugging the root cause.
@michaelsproul
Copy link
Member Author

In v3.3.0 this will present as WARN Failed to finalize deposit cache

@michaelsproul michaelsproul added v3.4.0 Minor release following v3.3.0 and removed v3.3.0 Minor release following v3.2.0 labels Nov 24, 2022
macladson pushed a commit to macladson/lighthouse that referenced this issue Jan 5, 2023
@michaelsproul @macladson
Lower deposit finalization error to warning (sigp#3739)
3925691 
## Issue Addressed

Partially addresses sigp#3707

## Proposed Changes

Drop `ERRO` log to `WARN` until we identify the exact conditions that lead to this case.

Add a message which hopefully reassures users who only see this log once 😅 

Add the block hash to the error message in case it will prove useful in debugging the root cause.
@paulhauner paulhauner added v3.5.0 Minor release circa Q1 2023 and removed v3.4.0 Minor release following v3.3.0 labels Jan 9, 2023
@paulhauner
Copy link
Member

I've pushed this to v3.5.0, LMK if this is an issue @michaelsproul ☺️

@michaelsproul michaelsproul removed the v3.5.0 Minor release circa Q1 2023 label Feb 13, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@michaelsproul @Woodpile37
Lower deposit finalization error to warning (sigp#3739)
a20906d 
## Issue Addressed

Partially addresses sigp#3707

## Proposed Changes

Drop `ERRO` log to `WARN` until we identify the exact conditions that lead to this case.

Add a message which hopefully reassures users who only see this log once 😅 

Add the block hash to the error message in case it will prove useful in debugging the root cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @paulhauner