Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement liveness BeaconAPI #4243

Closed
nalepae opened this issue Apr 27, 2023 · 3 comments
Closed

Implement liveness BeaconAPI #4243

nalepae opened this issue Apr 27, 2023 · 3 comments
Labels
backwards-incompat Backwards-incompatible API change good first issue Good for newcomers HTTP-API

Comments

@nalepae
Copy link
Contributor

nalepae commented Apr 27, 2023

Description

Beacon API v2.4.0 defines a liveness endpoint (in some ways similar to this).

Does the Lighthouse team plan to implement it?

EDIT: Replace link in "in some ways similar to" by the good one.

@michaelsproul
Copy link
Member

Yeah we do! There's an existing liveness endpoint that our doppelganger detection uses, so implementing the standard API should just be a straight-forward port of that: https://lighthouse-book.sigmaprime.io/api-lighthouse.html#lighthouseliveness.

Deciding how to handle it in the VC is slightly more complicated. We could switch to the standard endpoint as soon as it's available, but this would break compatibility with older versions of the Lighthouse BN. Alternatively we could wait a release or two before switching over the VC. I think I prefer switching immediately, as most users will update VC+BN together anyway.

@michaelsproul michaelsproul added good first issue Good for newcomers HTTP-API backwards-incompat Backwards-incompatible API change labels Apr 27, 2023
@nalepae
Copy link
Contributor Author

nalepae commented Apr 27, 2023

Thanks!

I edited the ticket description with the good link! (I copy/pasted the wrong one.)

bors bot pushed a commit that referenced this issue Jul 31, 2023
## Issue Addressed

#4243

## Proposed Changes

- create a new endpoint for liveness/{endpoint}

## Additional Info
This is my first PR.
@jimmygchen
Copy link
Member

Completed in #4343

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
## Issue Addressed

sigp#4243

## Proposed Changes

- create a new endpoint for liveness/{endpoint}

## Additional Info
This is my first PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change good first issue Good for newcomers HTTP-API
Projects
None yet
Development

No branches or pull requests

3 participants