-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement liveness
BeaconAPI
#4243
Comments
Yeah we do! There's an existing liveness endpoint that our doppelganger detection uses, so implementing the standard API should just be a straight-forward port of that: https://lighthouse-book.sigmaprime.io/api-lighthouse.html#lighthouseliveness. Deciding how to handle it in the VC is slightly more complicated. We could switch to the standard endpoint as soon as it's available, but this would break compatibility with older versions of the Lighthouse BN. Alternatively we could wait a release or two before switching over the VC. I think I prefer switching immediately, as most users will update VC+BN together anyway. |
Thanks! I edited the ticket description with the good link! (I copy/pasted the wrong one.) |
## Issue Addressed #4243 ## Proposed Changes - create a new endpoint for liveness/{endpoint} ## Additional Info This is my first PR.
Completed in #4343 |
## Issue Addressed sigp#4243 ## Proposed Changes - create a new endpoint for liveness/{endpoint} ## Additional Info This is my first PR.
Description
Beacon API
v2.4.0
defines a liveness endpoint (in some ways similar to this).Does the Lighthouse team plan to implement it?
EDIT: Replace link in "in some ways similar to" by the good one.
The text was updated successfully, but these errors were encountered: