We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presently, when the lighthouse binary is started an Environment is created which contains an Eth2Config.
lighthouse
Environment
Eth2Config
Then, this code ignores the environment.eth2_spec and replaces the Eth2Config in it's local context.
environment.eth2_spec
This means that there's no guarantee of consistency of the Eth2Config from an Environment.
ArgMatches
config.rs
environment
This issue is only valid after #542 is merged.
The text was updated successfully, but these errors were encountered:
Hi, I'm addressing this issue, will file a PR to close this. 😃
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Description
Presently, when the
lighthouse
binary is started anEnvironment
is created which contains anEth2Config
.Then, this code ignores the
environment.eth2_spec
and replaces theEth2Config
in it's local context.This means that there's no guarantee of consistency of the
Eth2Config
from anEnvironment
.Steps to resolve
Eth2Config
from CLI args (ArgMatches
) (see [config.rs
])(https://github.com/sigp/lighthouse/blob/eth1/beacon_node/src/config.rs) and place it in it's own function in theenvironment
crate.Notes
This issue is only valid after #542 is merged.
The text was updated successfully, but these errors were encountered: