Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attestation service test suite #1070

Merged
merged 3 commits into from
May 10, 2020
Merged

Attestation service test suite #1070

merged 3 commits into from
May 10, 2020

Conversation

realbigsean
Copy link
Member

Issue Addressed

#886

Proposed Changes

Adds tests for the attestation service.

Additional Info

Let me know of any other scenarios I should add.

@paulhauner paulhauner added the ready-for-review The code is ready for review label Apr 30, 2020
AgeManning
AgeManning approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for this!

@AgeManning AgeManning merged commit 2692c77 into sigp:master May 10, 2020
@AgeManning AgeManning mentioned this pull request May 13, 2020
Closed
@realbigsean realbigsean mentioned this pull request May 19, 2020
Merged
@realbigsean realbigsean deleted the attestation-service-test-suite branch November 21, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realbigsean @AgeManning @paulhauner