Remove active validators crate #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
None
Proposed Changes
Removes the
active_validatorcrate.Additional Info
I feel the functionality of this crate is not enough to warrant an entire crate. If someone else disagrees, we can talk it through -- I'm not too strongly attached but it was an easy PR to make.
If anything, I would prefer to see a
struct Validators(Vec<ValidatorRecord>);newtype with methods likeactive_indices(&self) -> Vec<usize>and things like that. The newtype pattern adds a bit of overhead which at the moment I don't think is justified. If we get more and more instances where we want to talk about a group of validators then I would push harder for this.