Add explicit bounds for ssz decoding in rpc #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update milagro_bls to new release Signed-off-by: Kirk Baird <baird.k@outlook.com> * Tidy up fake cryptos Signed-off-by: Kirk Baird <baird.k@outlook.com> * move SecretHash to bls and put plaintext back Signed-off-by: Kirk Baird <baird.k@outlook.com>
AgeManning
reviewed
Jun 11, 2020
There was a problem hiding this comment.
This seems to build on top of #1837. I will wait for this to merge before reviewing
AgeManning
approved these changes
Jun 12, 2020
pawanjay176
commented
Jun 12, 2020
| use types::{BeaconBlock, EthSpec, Hash256, MainnetEthSpec, Signature, SignedBeaconBlock}; | ||
|
|
||
| lazy_static! { | ||
| pub static ref SIGNED_BEACON_BLOCK_MIN: usize = SignedBeaconBlock::<MainnetEthSpec> { |
There was a problem hiding this comment.
@AgeManning is it okay here that I'm sorta hardcoding MainnetEthSpec? I couldn't figure out how to keep it generic over EthSpec.
There was a problem hiding this comment.
This looks fine to me.
Add a comment indicating we are doing this and that the MAX/MIN values are the same across each spec type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
ethereum/consensus-specs#1800
Also contains spec updates from #1244 to avoid double work.
Proposed Changes
SignedBeaconBlockandBlocksByRootRequest)Note: The spec also mentions the following validation check
This PR does not contain this check as any length prefix > 10 bytes would error at the Uvi codec length decoding anyway. Adding this check explicitly will simply complicate the logic.