[Merged by Bors] - Server sent events #1920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-sent-events � Conflicts: � beacon_node/client/src/builder.rs � beacon_node/http_api/src/lib.rs
…er-sent-events � Conflicts: � common/eth2/src/types.rs
…ttp server is started
…er-sent-events � Conflicts: � Cargo.lock
…rver-sent-events � Conflicts: � README.md � beacon_node/beacon_chain/src/beacon_chain.rs � beacon_node/client/src/builder.rs � beacon_node/http_api/src/lib.rs � beacon_node/http_api/tests/tests.rs � beacon_node/src/lib.rs
realbigsean
added
ready-for-review
…rver-sent-events � Conflicts: � Cargo.lock � beacon_node/beacon_chain/Cargo.toml � beacon_node/http_api/src/lib.rs � beacon_node/http_api/tests/tests.rs � beacon_node/websocket_server/Cargo.toml � beacon_node/websocket_server/src/lib.rs
…rver-sent-events � Conflicts: � Cargo.lock
…rver-sent-events � Conflicts: � beacon_node/beacon_chain/src/builder.rs � beacon_node/client/src/builder.rs
paulhauner
approved these changes
Dec 4, 2020
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 4, 2020
## Issue Addressed Resolves #1434 (this is the last major feature in the standard spec. There are only a couple of places we may be off-spec due to recent spec changes or ongoing discussion) Partly addresses #1669 ## Proposed Changes - remove the websocket server - remove the `TeeEventHandler` and `NullEventHandler` - add server sent events according to the eth2 API spec ## Additional Info This is according to the currently unmerged PR here: ethereum/beacon-APIs#117 Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #1434 (this is the last major feature in the standard spec. There are only a couple of places we may be off-spec due to recent spec changes or ongoing discussion)
Partly addresses #1669
Proposed Changes
TeeEventHandlerandNullEventHandlerAdditional Info
This is according to the currently unmerged PR here: ethereum/beacon-APIs#117