[Merged by Bors] - No string in slog #2017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, just to be sure before the repetitive task of find replace, the assembly of fn main() {
let x = "x";
println!("{}", x);
}is 100 lines long, fn main() {
let x = "x";
println!("{}", &x.to_string());
}is 150 lines long. So I assume this is an optimization the compiler / llvm does not do, so it's worth the "extra" effort of using |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
## Issue Addressed Following slog's documentation, this should help a bit with string allocations. I left it run for two days and mem usage is lower. This is of course anecdotal, but shouldn't harm anyway ## Proposed Changes remove `String` creation in logs when possible
|
bors retry? this doesn't seem related |
|
🔒 Permission denied Existing reviewers: click here to make divagant-martian a reviewer |
|
Pull request successfully merged into unstable. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Following slog's documentation, this should help a bit with string allocations. I left it run for two days and mem usage is lower. This is of course anecdotal, but shouldn't harm anyway
Proposed Changes
remove
Stringcreation in logs when possible