Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Minor fixes #2038

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Minor fixes #2038

wants to merge 4 commits into from

Conversation

pawanjay176
Copy link
Member

@pawanjay176 pawanjay176 commented Dec 2, 2020 •
edited

Fixes a couple of low hanging fruits.

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Dec 2, 2020
michaelsproul
michaelsproul approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bellissimo 👌

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 2, 2020
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 3, 2020
@pawanjay176
Minor fixes (#2038)
4826951 
Fixes a couple of low hanging fruits.

- Fixes #2037 
- `validators-dir` and `secrets-dir` flags don't really need to depend upon each other
- Fixes #2006 and Fixes #1995
@bors
Copy link

bors bot commented Dec 3, 2020

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Minor fixes [Merged by Bors] - Minor fixes Dec 3, 2020
@bors bors bot closed this Dec 3, 2020
This was referenced Dec 3, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawanjay176 @michaelsproul