Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Downgrades a valid log #2057

Closed
wants to merge 3 commits into from
Closed

Conversation

AgeManning
Copy link
Member

Issue Addressed

#2046

Proposed Changes

The log was originally intended to verify the correct logic and ordering of events when scoring peers. The queued tasks can be structured in such a way that peers can be banned after they are disconnected. Therefore the error log is now downgraded to debug log.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Dec 7, 2020
@AgeManning
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 8, 2020
## Issue Addressed

#2046 

## Proposed Changes

The log was originally intended to verify the correct logic and ordering of events when scoring peers. The queued tasks can be structured in such a way that peers can be banned after they are disconnected. Therefore the error log is now downgraded to  debug log.
@bors
Copy link

bors bot commented Dec 8, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 8, 2020
## Issue Addressed

#2046 

## Proposed Changes

The log was originally intended to verify the correct logic and ordering of events when scoring peers. The queued tasks can be structured in such a way that peers can be banned after they are disconnected. Therefore the error log is now downgraded to  debug log.
@bors
Copy link

bors bot commented Dec 8, 2020

Build failed:

@AgeManning
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 8, 2020
## Issue Addressed

#2046 

## Proposed Changes

The log was originally intended to verify the correct logic and ordering of events when scoring peers. The queued tasks can be structured in such a way that peers can be banned after they are disconnected. Therefore the error log is now downgraded to  debug log.
@bors bors bot changed the title Downgrades a valid log [Merged by Bors] - Downgrades a valid log Dec 8, 2020
@bors bors bot closed this Dec 8, 2020
@AgeManning AgeManning deleted the downgrade-log branch January 7, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants