[Merged by Bors] - Address ENR update loop #2216
Conversation
beacon_node/eth2_libp2p/Cargo.toml
Outdated
| @@ -5,7 +5,7 @@ authors = ["Sigma Prime <contact@sigmaprime.io>"] | |||
| edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| discv5 = { version = "0.1.0-beta.3", features = ["libp2p"] } | |||
| discv5 = { git = "https://github.com/sigp/discv5 ", branch = "enr-loop", features = ["libp2p"] } | |||
There was a problem hiding this comment.
We should use the hash in master, so that when the branch gets removed this commit still works
There was a problem hiding this comment.
Waiting on sigp/discv5#63 to merge then I can use the master commit.
|
I've pushed an updated docker image to paulhauner/lighthouse:v1.1.2-hotfix.1. I recommend any users that are experiencing the issue in #2215 to either compile from this branch or use the aformentioned docker image. We will push a formal hotfix release next week once we've passed review and full pre-release testing. |
|
Just pulled the new image, I think it resolved the problem, will continue monitoring to confirm. Appreciate the really fast turnaround on this! |
|
bors r+ |
## Issue Addressed - Resolves #2215 ## Proposed Changes Addresses a potential loop when the majority of peers indicate that we are contactable via an IPv6 address. See sigp/discv5#62 for further rationale. ## Additional Info The alternative to this PR is to use `--disable-enr-auto-update` and then manually supply an `--enr-address` and `--enr-upd-port`. However, that requires the user to know their IP addresses in order for discovery to work properly. This might not be practical/achievable for some users, hence this hotfix.
|
bors r- Trying to batch |
|
Canceled. |
|
bors r+ |
## Issue Addressed - Resolves #2215 ## Proposed Changes Addresses a potential loop when the majority of peers indicate that we are contactable via an IPv6 address. See sigp/discv5#62 for further rationale. ## Additional Info The alternative to this PR is to use `--disable-enr-auto-update` and then manually supply an `--enr-address` and `--enr-upd-port`. However, that requires the user to know their IP addresses in order for discovery to work properly. This might not be practical/achievable for some users, hence this hotfix.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Issue Addressed
Proposed Changes
Addresses a potential loop when the majority of peers indicate that we are contactable via an IPv6 address.
See sigp/discv5#62 for further rationale.
Additional Info
The alternative to this PR is to use
--disable-enr-auto-updateand then manually supply an--enr-addressand--enr-upd-port. However, that requires the user to know their IP addresses in order for discovery to work properly. This might not be practical/achievable for some users, hence this hotfix.