Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix false positive "State advance too slow" logs #2218

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix false positive "State advance too slow" logs #2218

wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

Proposed Changes

Fix the false positive warning log described in #2214.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Feb 21, 2021
@paulhauner paulhauner changed the base branch from stable to unstable February 21, 2021 23:05
michaelsproul
michaelsproul approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 21, 2021
@paulhauner
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Feb 21, 2021

👎 Rejected by PR status

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 21, 2021
@paulhauner
Fix false positive "State advance too slow" logs (#2218)
4362ea4 
## Issue Addressed

- Resolves #2214

## Proposed Changes

Fix the false positive warning log described in #2214.

## Additional Info

NA
@bors
Copy link

bors bot commented Feb 22, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Fix false positive "State advance too slow" logs [Merged by Bors] - Fix false positive "State advance too slow" logs Feb 22, 2021
@bors bors bot closed this Feb 22, 2021
@paulhauner paulhauner mentioned this pull request Feb 22, 2021
Closed
@paulhauner paulhauner deleted the state-warning branch March 17, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive WARN logs State advance too slow
2 participants
@paulhauner @michaelsproul