[Merged by Bors] - Correcting disable-enr-auto-update flag definition
#2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nice one @macladson! It seems like a no-brainer that this is correct, but I just wanted to double-check with @AgeManning in case he's doing anything funky :) |
paulhauner
added
ready-for-review
paulhauner
approved these changes
Apr 7, 2021
|
ahah yeah. I've had this as a diff in my local branches for ages, just never committed. I think we should remove the entire line, its a bit cleaner. Otherwise lgtm |
AgeManning
approved these changes
Apr 7, 2021
|
Nice, I've removed the line. I only kept it in because I saw some other flags where it was explicit. |
|
Noting that this is a breaking API change to the CLI, which we should highlight in the next release (which should be v1.3.0) |
michaelsproul
added
backwards-incompat
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2021
## Issue Addressed N/A ## Proposed Changes Correct the `disable-enr-auto-update` boolean flag so that it no longer requires a value. Previously it would require a value which was never used. ## Additional Info Flag is read here: https://github.com/sigp/lighthouse/blob/unstable/beacon_node/src/config.rs#L585-L587
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
disable-enr-auto-update flag definitiondisable-enr-auto-update flag definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Correct the
disable-enr-auto-updateboolean flag so that it no longer requires a value.Previously it would require a value which was never used.
Additional Info
Flag is read here: https://github.com/sigp/lighthouse/blob/unstable/beacon_node/src/config.rs#L585-L587