[Merged by Bors] - Add NETWORK_ID variable #2330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @pawanjay176, do you mind eyeballing this please? :) |
Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com>
pawanjay176
added
ready-for-merge
|
bors r+ |
|
👎 Rejected by PR status |
|
bors retry |
|
👎 Rejected by PR status |
|
bors r- |
bors bot
pushed a commit
that referenced
this pull request
May 12, 2021
Same variable BOOTNODE_PORT was used for p2p port of bootnode and testnet Chain and Network ID. Adding variable NETWORK_ID to make scripts less confusing and create option to choose arbitrary ID. Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com> Co-authored-by: Michael Sproul <michael@sigmaprime.io>
|
Sorry for the comment spam. I had to twiddle the code to get CI to recognise the change of base branch. It's a bit counter-intuitive but PRs need to target Thanks for the contrib @taxmeifyoucan! |
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same variable BOOTNODE_PORT was used for p2p port of bootnode and testnet Chain and Network ID. Adding variable NETWORK_ID to make scripts less confusing and create option to choose arbitrary ID.