Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Lower penalty for past/future slot errors #2510

Closed
wants to merge 1 commit into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Reduce the penalties with past/future slot errors for sync committee messages.

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Aug 12, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bors r+

bors bot pushed a commit that referenced this pull request Aug 16, 2021
## Issue Addressed

N/A

## Proposed Changes

Reduce the penalties with past/future slot errors for sync committee messages.
@paulhauner
Copy link
Member

Actually, I might even loosen this more.

bors r-

@bors
Copy link

bors bot commented Aug 16, 2021

Canceled.

@paulhauner
Copy link
Member

Actually, lets roll with this for now. I'll make another PR if we decide to become even more lenient.

Previously I was thinking that HighTolerance is -5, but it's actually -1.

bors r+

bors bot pushed a commit that referenced this pull request Aug 16, 2021
## Issue Addressed

N/A

## Proposed Changes

Reduce the penalties with past/future slot errors for sync committee messages.
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v1.5.0 For inclusion in v1.5.0 release and removed ready-for-review The code is ready for review labels Aug 16, 2021
@bors bors bot changed the title Lower penalty for past/future slot errors [Merged by Bors] - Lower penalty for past/future slot errors Aug 17, 2021
@bors bors bot closed this Aug 17, 2021
pawanjay176 added a commit to pawanjay176/lighthouse that referenced this pull request Aug 27, 2021
## Issue Addressed

N/A

## Proposed Changes

Reduce the penalties with past/future slot errors for sync committee messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v1.5.0 For inclusion in v1.5.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants