[Merged by Bors] - Fix cargo audit warns for nix, psutil, time #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
This was referenced Oct 10, 2021
AgeManning
approved these changes
Oct 11, 2021
|
bors r+ |
michaelsproul
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
## Issue Addressed Fix `cargo audit` failures on `unstable` Closes #2698 ## Proposed Changes The main culprit is `nix`, which is vulnerable for versions below v0.23.0. We can't get by with a straight-forward `cargo update` because `psutil` depends on an old version of `nix` (cf. rust-psutil/rust-psutil#93). Hence I've temporarily forked `psutil` under the `sigp` org, where I've included the update to `nix` v0.23.0. Additionally, I took the chance to update the `time` dependency to v0.3, which removed a bunch of stale deps including `stdweb` which is no longer maintained. Lighthouse only uses the `time` crate in the notifier to do some pretty printing, and so wasn't affected by any of the breaking changes in v0.3 ([changelog here](https://github.com/time-rs/time/blob/main/CHANGELOG.md#030-2021-07-30)).
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix
cargo auditfailures onunstableCloses #2698
Proposed Changes
The main culprit is
nix, which is vulnerable for versions below v0.23.0. We can't get by with a straight-forwardcargo updatebecausepsutildepends on an old version ofnix(cf. rust-psutil/rust-psutil#93). Hence I've temporarily forkedpsutilunder thesigporg, where I've included the update tonixv0.23.0.Additionally, I took the chance to update the
timedependency to v0.3, which removed a bunch of stale deps includingstdwebwhich is no longer maintained. Lighthouse only uses thetimecrate in the notifier to do some pretty printing, and so wasn't affected by any of the breaking changes in v0.3 (changelog here).