Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Update to ethereum-types 0.5.0 #216
Proposed Changes
ethereum-types
to 0.5(.2)from_slice
to convert byte slices toHash256
, asHash256::from
for slices has been removedas_bytes
conversions forHash256
to&[u8]
. Previously not required due to a now-removedDeref
implint_to_bytes32
ingenerate_seed
to avoid confusion (spec)teleport_to_end_of_epoch
with arbitrary byte arraysHash256::from_short_slice
mixin to ease compatibility with existing tests that use slices of length less than 32Additional Info
I'd like feedback on the last two points in particular, which feel a little bit suspect – particularly
from_short_slice
. We could do away with that extra complexity by using arbitrary byte arrays in the tests instead of strings like"some hash"
.