[Merged by Bors] - Optimise balances cache in case of skipped slots #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2021
|
I've implemented a schema migration for this change to address the issue described here: https://hackmd.io/@sproul/HyUjTaSFY The migration is here: michaelsproul@f1496b9 I'll push it to this branch once #2822 is merged |
michaelsproul
added
blocked
and removed
work-in-progress
michaelsproul
force-pushed
the
balances-cache-skip
branch
from
0df386b
to
efd5184
Compare
michaelsproul
force-pushed
the
balances-cache-skip
branch
from
efd5184
to
549e5b9
Compare
paulhauner
approved these changes
Dec 13, 2021
michaelsproul
added
ready-for-merge
michaelsproul
force-pushed
the
balances-cache-skip
branch
from
549e5b9
to
ec94984
Compare
|
Going to try an optimistic merge! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2021
## Proposed Changes Remove the `is_first_block_in_epoch` logic from the balances cache update logic, as it was incorrect in the case of skipped slots. The updated code is simpler because regardless of whether the block is the first in the epoch we can check if an entry for the epoch boundary root already exists in the cache, and update the cache accordingly. Additionally, to assist with flip-flopping justified epochs, move to cloning the balance cache rather than moving it. This should still be very fast in practice because the balances cache is a ~1.6MB `Vec`, and this operation is expected to only occur infrequently.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the
is_first_block_in_epochlogic from the balances cache update logic, as it was incorrect in the case of skipped slots. The updated code is simpler because regardless of whether the block is the first in the epoch we can check if an entry for the epoch boundary root already exists in the cache, and update the cache accordingly.Additionally, to assist with flip-flopping justified epochs, move to cloning the balance cache rather than moving it. This should still be very fast in practice because the balances cache is a ~1.6MB
Vec, and this operation is expected to only occur infrequently.