Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - local testnet: Fix an error on startup #2973

Closed
wants to merge 1 commit into from

Conversation

ackintosh
Copy link
Member

Issue Addressed

Resolves #2763 (comment)

Proposed Changes

  • Skip if the line is blank. 馃憣

@ackintosh
Copy link
Member Author

https://github.com/sigp/lighthouse/runs/4994557190?check_suite_focus=true

Ah, the error in CI (run-local-testnet) is a timing issue between ganache-cli and BeaconNode/ValidatorClient.
This will be fixed via #2970 .

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Jan 31, 2022
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 31, 2022
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 31, 2022
## Issue Addressed

Resolves #2763 (comment)

## Proposed Changes

- Skip if the line is blank. 馃憣
@bors bors bot changed the title local testnet: Fix an error on startup [Merged by Bors] - local testnet: Fix an error on startup Feb 1, 2022
@bors bors bot closed this Feb 1, 2022
@ackintosh ackintosh deleted the empty-pids-file branch February 1, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants