[Merged by Bors] - [DEV FEATURE] Deterministic long lived subnets #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
force-pushed
the
attnet-subscription
branch
2 times, most recently
from
0267f17
to
1da0a7d
Compare
divagant-martian
force-pushed
the
attnet-subscription
branch
from
1b831f7
to
ee44ce2
Compare
michaelsproul
added
v3.2.0
|
Once the merge conflict is fixed and the dust has settled from v3.1.2, we can merge 🚀 |
|
don't think we want this merge tho, @AgeManning ? |
|
Yeah I think we do want this, as long as the default is the usual behaviour. The compile-time flag enables this extra functionality and is handy for further testing |
AgeManning
added
ready-for-merge
|
@AgeManning this is what's been running in wood (so, without the feature on) all this time and to me it looks good |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
## Issue Addressed #2847 ## Proposed Changes Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way ## Additional Info There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## Issue Addressed #2847 ## Proposed Changes Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way ## Additional Info There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## Issue Addressed #2847 ## Proposed Changes Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way ## Additional Info There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## Issue Addressed #2847 ## Proposed Changes Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way ## Additional Info There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed sigp#2847 ## Proposed Changes Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way ## Additional Info There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#2847
Proposed Changes
Add under a feature flag the required changes to subscribe to long lived subnets in a deterministic way
Additional Info
There is an additional required change that is actually searching for peers using the prefix, but I find that it's best to make this change in the future