New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Use efficient payload reconstruction for HTTP API #4102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
force-pushed
the
payload_bodies_http
branch
from
April 17, 2023 09:15
2df4f8d
to
cdef32e
Compare
michaelsproul
changed the title
Payload bodies http
Use efficient payload reconstruction for HTTP API
Apr 17, 2023
michaelsproul
added
v4.2.0
Q2 2023
v4.1.0
Post-Capella minor release
and removed
v4.2.0
Q2 2023
labels
Apr 17, 2023
michaelsproul
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Apr 18, 2023
paulhauner
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tidy!
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Apr 18, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
## Proposed Changes Builds on #4028 to use the new payload bodies methods in the HTTP API as well. ## Caveats The payloads by range method only works for the finalized chain, so it can't be used in the execution engine integration tests because we try to reconstruct unfinalized payloads there.
Pull request successfully merged into unstable. Build succeeded:
|
bors
bot
changed the title
Use efficient payload reconstruction for HTTP API
[Merged by Bors] - Use efficient payload reconstruction for HTTP API
Apr 18, 2023
xenowits
pushed a commit
to xenowits/lighthouse
that referenced
this pull request
May 16, 2023
## Proposed Changes Builds on sigp#4028 to use the new payload bodies methods in the HTTP API as well. ## Caveats The payloads by range method only works for the finalized chain, so it can't be used in the execution engine integration tests because we try to reconstruct unfinalized payloads there.
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Proposed Changes Builds on sigp#4028 to use the new payload bodies methods in the HTTP API as well. ## Caveats The payloads by range method only works for the finalized chain, so it can't be used in the execution engine integration tests because we try to reconstruct unfinalized payloads there.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Builds on sigp#4028 to use the new payload bodies methods in the HTTP API as well. The payloads by range method only works for the finalized chain, so it can't be used in the execution engine integration tests because we try to reconstruct unfinalized payloads there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Builds on #4028 to use the new payload bodies methods in the HTTP API as well.
Caveats
The payloads by range method only works for the finalized chain, so it can't be used in the execution engine integration tests because we try to reconstruct unfinalized payloads there.