Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed block logs #4922

Merged
merged 1 commit into from Nov 16, 2023
Merged

Fix missed block logs #4922

merged 1 commit into from Nov 16, 2023

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Nov 12, 2023 •
edited

Proposed Changes

Without this patch Lighthouse frequently logs:

Nov 12 14:16:53.206 WARN Missing validator index index: 313814, info: potentially inconsistency in the validator manager, service: val_mon, service: beacon

The reason is that self.indices contains indices for all validators, while self.pubkeys only contains pubkeys for monitored validators. The log occurs when a non-monitored validator misses a block.

Bug was introduced in #4731

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs labels Nov 12, 2023
jimmygchen
jimmygchen approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 13, 2023
@v4lproik
Copy link
Contributor

Sorry, that's from my PR! I just compiled a new version of the unstable branch with this fix and deployed it to our infra and it indeed removes the warning message highlighted by Michael.

Also I have loaded the validator monitor with 15k of pub keys on Goerli for a short period of time, the time to have enough data to update the new charts in the metrics repository according to the latest version of #4731.

@jimmygchen jimmygchen merged commit d04e361 into sigp:unstable Nov 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. UX-and-logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelsproul @v4lproik @jimmygchen