Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mergify commit message template to use PR title instead of commit message #5126

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Update Mergify commit message template to use PR title (instead of commit message) as the commit message title, and have commits in the description, like below:

commit 337aec07bd39bc3c478d94b92de2a0bc2a1496a3 (HEAD -> unstable, jimmygchen/unstable)
Author: Jimmy Chen <jchen.tc@gmail.com>
Date:   Thu Jan 25 15:53:49 2024 +1100

    My PR title (#47)
    
    * bello
    
    * Banana
    
    * Make CI instant again
        
    * Merge remote-tracking branch 'jimmygchen/unstable' into bello

@jimmygchen jimmygchen added ready-for-review The code is ready for review infra-ci labels Jan 25, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 25, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Jan 25, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio refresh

Copy link

mergify bot commented Jan 25, 2024

refresh

✅ Pull request refreshed

@jimmygchen
Copy link
Member Author

@mergify refresh

Copy link

mergify bot commented Jan 25, 2024

refresh

✅ Pull request refreshed

@jimmygchen
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jan 25, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean
Copy link
Member

@mergify refresh

Copy link

mergify bot commented Jan 25, 2024

refresh

✅ Pull request refreshed

@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jan 25, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Jan 26, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio refresh

Copy link

mergify bot commented Jan 26, 2024

refresh

✅ Pull request refreshed

@michaelsproul
Copy link
Member

I think Mergify is stuck with a cached build status. It might be expecting a new commit on this branch

@jimmygchen
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jan 26, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #5126 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member Author

jimmygchen commented Jan 26, 2024

I think Mergify is stuck with a cached build status. It might be expecting a new commit on this branch

hmm that's annoying :/ I've pushed an empty commit to trigger a new workflow, and re-queued this PR.

@jimmygchen
Copy link
Member Author

@Mergifyio refresh

Copy link

mergify bot commented Jan 26, 2024

refresh

✅ Pull request refreshed

@jimmygchen
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jan 27, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c7e5dd1

@mergify mergify bot merged commit c7e5dd1 into sigp:unstable Jan 27, 2024
29 checks passed
@jimmygchen jimmygchen deleted the mergify-commit-msg branch January 27, 2024 04:07
danielramirezch pushed a commit to danielramirezch/lighthouse that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants