Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging level when using logfile #721

Merged
merged 1 commit into from Dec 13, 2019

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Dec 12, 2019

Issue Addressed

Closes #638

Proposed Changes

Add support for logging level when using the --logfile flag.

Additional Info

Tested it myself using different combination of flags, I believe it's working as intended. :D

@paulhauner paulhauner self-requested a review December 13, 2019 05:07
@paulhauner paulhauner self-assigned this Dec 13, 2019
@paulhauner paulhauner added the ready-for-review The code is ready for review label Dec 13, 2019
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@paulhauner paulhauner merged commit b1d4284 into sigp:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--debug-level flag not working
2 participants