[WIP] Tree hash #88
[WIP] Tree hash #88
Conversation
There was a problem hiding this comment.
Looks like you've been busy and are making good progress!
I've focused on picking up project-consistency type issues here, as I figure this is the type of feedback you're after.
I can see there's going to be a lot of work around implementing tree hashing in it's entirety for all required types. For this reason, I think it might be sensible to re-scope this PR to be around implementing the core recursive hashing logic and only implementing it on a single (recursive) type. CrystallizedState seems to be the best candidate for this.
It appears to me that it would be very valuable to have some test vectors at this point. I will go prod the EF research team and let you know how it goes.
In terms of moving forward, I'll let you process my comments and I'll chase up test vectors. Once we have completed that, we can regroup and move towards a finalized implementation that is provably correct in some aspects.
Of course, feel free to ping me on Gitter with questions :)
… various cleanup code
Required for part of attestation validation logic
… various cleanup code
|
Updated to the latest spec changes. Still needs tie-out testing when available. |
|
FYI, I just followed up on finding a blessed impl from the EF that we can test with. EDIT: If they don't get something in a timely manner I think we just merge this in and then update later if required. |
|
Oh no, I missed the conflicts! If you can resolve I'll merge :) |
|
Yeah, I just saw this - sorry, it's pretty out of date. I'll create a new branch, if that's cool. I think it'll be cleaner. |
|
Moved to #169 |
Issue Addressed
Which issue # does this PR address?
#70
Proposed Changes
Added a Tree_Hash trait to relevant types with supporting functions
Additional Info
Still need to implement lists (Vec) and Container (HashMap - If I understand correctly) types. This a WIP/ sanity review request.