Fix issues with testnet dir, update docs #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
work-in-progress
AgeManning
added a commit
that referenced
this pull request
Apr 13, 2020
paulhauner
added
work-in-progress
AgeManning
reviewed
Apr 14, 2020
AgeManning
added a commit
that referenced
this pull request
Apr 14, 2020
* Second update for this PR
Co-Authored-By: Age Manning <Age@AgeManning.com>
paulhauner
added
ready-for-review
|
Purging has been updated @michaelsproul :) |
| @@ -221,7 +221,7 @@ where | |||
| .get::<PersistedBeaconChain>(&Hash256::from_slice(&BEACON_CHAIN_DB_KEY)) | |||
| .map_err(|e| format!("DB error when reading persisted beacon chain: {:?}", e))? | |||
| .ok_or_else(|| { | |||
| "No persisted beacon chain found in store. Try purging the beacon chain database." | |||
| "No persisted beacon chain found in store. Try deleting the .lighthouse/beacon dir." | |||
There was a problem hiding this comment.
I think this should stay as it was
beacon_node/src/config.rs
Outdated
| @@ -294,6 +291,39 @@ pub fn get_config<E: EthSpec>( | |||
| client_config.network.discovery_address = | |||
| Some("127.0.0.1".parse().expect("Valid IP address")) | |||
| } | |||
|
|
|||
| /* | |||
| * Load the eth2 testnet dir to obtain some addition config values. | |||
book/src/simple-testnet.md
Outdated
| @@ -1,70 +1 @@ | |||
| # Simple Local Testnet | |||
There was a problem hiding this comment.
This file is just a heading, I think we should delete it?
There was a problem hiding this comment.
Thanks! mdbook has an annoying habit of creating a file if it's listed in SUMMARY.md but doesn't exist.
michaelsproul
added
waiting-on-author
michaelsproul
approved these changes
Apr 17, 2020
paulhauner
added
ready-for-review
|
All comments addressed! :) |
paulhauner
added
ready-to-squerge
and removed
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Fixes a bug introduced in #912 (I assume) that broke some of the
bn testnet ...subcommands and also the--testnet-dircommand when the hardcoded testnet is invalid (which is the case now).Notably, this PR doesn't fix
bn testnet ...it only fixes--testnet-dirand then updates the docs to remove usages ofbn testnet ...in favor of--testnet-dir+lcli new-testnet.Additional Info
A later PR can strip out all the old
bn testnet ...subcommands.