Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-archive sigstore/sigstore-maven-plugin repo #45

Closed
bobcallaway opened this issue May 31, 2023 · 10 comments
Closed

un-archive sigstore/sigstore-maven-plugin repo #45

bobcallaway opened this issue May 31, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@bobcallaway
Copy link
Member

Description

https://github.com/sigstore/sigstore-maven-plugin was previously archived due to a desire to shift over to https://github.com/sigstore/sigstore-maven which was being built along side https://github.com/sigstore/sigstore-java. There have been 0 commits to https://github.com/sigstore/sigstore-maven in the past 8 months, and I received a request from @hboutemy to unarchive https://github.com/sigstore/sigstore-maven-plugin as they have a patch that would bring that plugin up to date with the latest developments.

@hboutemy, please add color/correct me where I've made any errors in describing the request.

FYI @sigstore/core-team @loosebazooka @jvanzyl

@bobcallaway bobcallaway added the enhancement New feature or request label May 31, 2023
@jvanzyl
Copy link

jvanzyl commented May 31, 2023

Go for it, whatever moves Maven support along. I was chatting with Appu about just merging the code that's there into sigstore-java. So unarchiving and integrating with sigstore-java is what I'd suggest.

@dlorenc
Copy link
Member

dlorenc commented Jun 2, 2023

@jvanzyl are you still interested in helping maintain this in the other location?

@jvanzyl
Copy link

jvanzyl commented Jun 2, 2023

Yes, I'd like to continue to help when I can.

@hboutemy
Copy link

Hi @bobcallaway , what's the next step, please?

@bobcallaway
Copy link
Member Author

@SantiagoTorres @trevrosen @lukehinds @priyawadhwa any TSC objections? otherwise I will unarchive this.

@priyawadhwa
Copy link
Contributor

SGTM

@jvanzyl
Copy link

jvanzyl commented Jun 13, 2023

Great, look forward to working with you @hboutemy.

@hboutemy
Copy link

oh yes, I migrated the plugin to use the sigstore-java library, which is just a first step: there is much room for improvement after that

@hboutemy
Copy link

@bobcallaway everything looks good, isn't it?

@hboutemy
Copy link

hboutemy commented Jul 6, 2023

thank you @bobcallaway

loosebazooka added a commit to loosebazooka/community that referenced this issue Aug 30, 2023
hboutemy is currently working on github.com/sigstore/sigstore-maven-plugin which was unarchived sigstore/TSC#45 but does not have an entry in this project.

Signed-off-by: Appu <appu@google.com>
bobcallaway pushed a commit to sigstore/community that referenced this issue Sep 6, 2023
hboutemy is currently working on github.com/sigstore/sigstore-maven-plugin which was unarchived sigstore/TSC#45 but does not have an entry in this project.

Signed-off-by: Appu <appu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants