Skip to content

Commit

Permalink
Create new role for sigstore-bot in root-signing-staging (#395)
Browse files Browse the repository at this point in the history
* Create new role for sigstore-bot in root-signing-staging

* Role allows bypassing branch protections
* This replaces the use of a separate review bot
* Plan is to test this out in root-signing-staging, and later
  apply same structure to root-signing

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

* roles: Use different toplevel field name

The name is now consistently customRoles everywhere.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

* Custom role Use 'write' instead of 'push' as the base role

In pulumi args permission "push" usually seems to mean Github role
"write"... but that does not work for custom roles base role.

Use 'write' as the base role.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

---------

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
  • Loading branch information
jku committed Feb 7, 2024
1 parent 9dbbc2f commit 485faf7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 1 addition & 3 deletions github-sync/github-data/sigstore/repositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1467,9 +1467,7 @@ repositories:
- username: jku
permission: admin
- username: sigstore-bot
permission: push
- username: sigstore-review-bot
permission: push
permission: write-with-bypass
teams:
- name: tuf-root-signing-staging-codeowners
id: 8790813
Expand Down
5 changes: 5 additions & 0 deletions github-sync/github-data/sigstore/roles.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
customRoles:
- name: write-with-bypass
baseRole: write
description: write role with an additional permission to bypass branch protection
permissions: [bypass_branch_protection]

0 comments on commit 485faf7

Please sign in to comment.