-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user jku and team tuf-root-signing-staging-codeowners #348
Conversation
🍹
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* tuf-root-signing-staging-codeowners is for maintainers of planned root-signing-staging repository (see sigstore#345) * New user jku as well as kommendorkapten and haydentherapper are added to the new team * The repository is not defined yet as I understood the team needs to exist before it can have an id which is required to define the repository Fixes sigstore#347. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
741c7ec
to
03b22b1
Compare
can be togther, worst case we re-run the job :) |
I'll try something... the issues I have based on looking at the existing repository configs
I'll come up with something and I guess we'll see what pulumi preview says? EDIT: I have found the parser in sigstore/github-sync that seems to translate the sigstore config to something pulumi understands... the names being just slightly different from pulumi resources names was pretty hard to figure out |
Armed with some new understanding (that this is not a variant of pulumi yaml, this is a custom format parsed in sigstore/github-sync), I've tried to come up with a reasonable first configuration for the repository: Some changes will likely be needed later but this could work for now. currently preview fails with Looks like github.LookupTeam() is failing in https://github.com/sigstore/github-sync/blob/main/main.go#L149 when given "tuf-root-signing-staging-codeowners" as argument |
permission: push | ||
teams: | ||
- name: tuf-root-signing-staging-codeowners | ||
permission: maintain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this we will need to do in a follow up because we need to know the id for the team
f3de77f
to
03b22b1
Compare
Cheers. I removed the repository commit, this is now the original branch from two days ago:
|
cc @bobcallaway @trevrosen @lukehinds @priyawadhwa @SantiagoTorres for LGTM |
still waiting for a merge of this so that I could then add the new repository. @cpanato when this is merged, will I find the teamID in the workflow output or is there a more involved process to get it? |
you need to get that from the github api, i will do that |
but for reference you will need to run
and get the id :) |
Fixes #347
I don't really know what I'm doing with pulumi so feedback is welcome.