Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --yes to example workflow #110

Merged
merged 1 commit into from Mar 6, 2023
Merged

add --yes to example workflow #110

merged 1 commit into from Mar 6, 2023

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Mar 6, 2023

Summary

Version 2.0 of cosign is asking users to confirm that information is stored in public transparency logs. This interactive interaction does not work in automated CI pipelines like GitHub actions and breaks builds that are now starting to use 2.0. Adding --yes removes the required user interaction and enables automated builds again.

Release Note

NONE

Documentation

This PR updates the documentation in this repo. I could not find anything related to GitHub Actions in docs.sigstore.dev

@sebhoss
Copy link
Contributor Author

sebhoss commented Mar 6, 2023

It did not fit the PR template, but the 'error' log looks like this without the --yes flag:

Generating ephemeral keys...
Retrieving signed certificate...
Successfully verified SCT...

	Note that there may be personally identifiable information associated with this signed artifact.
	This may include the email address associated with the account with which you authenticate.
	This information will be used for signing this artifact and will be stored in public transparency logs and cannot be removed later.

By typing 'y', you attest that you grant (or have permission to grant) and agree to have this information stored permanently in transparency logs.
Are you sure you would like to continue? [y/N] Error: signing [docker.io/metio/devcontainers-nim@sha256:c7b300398d201e31b9ddead3b1947f33d40f75f2336c22bfef0017153a1d209a]: signing digest: should upload to tlog: user declined the prompt
main.go:74: error during command execution: signing [docker.io/metio/devcontainers-nim@sha256:c7b300398d201e31b9ddead3b1947f33d40f75f2336c22bfef0017153a1d209a]: signing digest: should upload to tlog: user declined the prompt

@cpanato
Copy link
Member

cpanato commented Mar 6, 2023

looks good, thanks
@sebhoss can you sign the DCO, please

Version 2.0 of cosign is asking users to confirm that information is
stored in public transparency logs. This interactive interaction does
not work in automated CI pipelines like GitHub actions and breaks
builds that are now starting to use 2.0. Adding --yes removes the
required user interaction and enables automated builds again.

Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@sebhoss
Copy link
Contributor Author

sebhoss commented Mar 6, 2023

Yep sorry I thought that I had auto-sign on :-\ should be good to go now

@cpanato cpanato merged commit bd2d118 into sigstore:main Mar 6, 2023
25 checks passed
anthonyfok added a commit to anthonyfok/python-env that referenced this pull request Mar 6, 2023
Fixes error where interactive prompt does not work in GitHub Actions CI.

See sigstore/cosign-installer#110
chantra added a commit to chantra/runner that referenced this pull request Mar 9, 2023
Our runs started to fail with https://gist.github.com/chantra/6ba6cdc65bd462bf082e8d8d0d91d02a

This is similar to sigstore/cosign-installer#110

Signed-off-by: Manu Bretelle <chantr4@gmail.com>
ianlewis pushed a commit to slsa-framework/slsa-github-generator that referenced this pull request Apr 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action |
minor | `v3.3.0` -> `v3.5.0` |
| [github/codeql-action](https://togithub.com/github/codeql-action) |
action | patch | `v2.2.9` -> `v2.2.11` |
|
[sigstore/cosign-installer](https://togithub.com/sigstore/cosign-installer)
| action | patch | `v3.0.1` -> `v3.0.2` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>actions/checkout</summary>

###
[`v3.5.0`](https://togithub.com/actions/checkout/releases/tag/v3.5.0)

[Compare
Source](https://togithub.com/actions/checkout/compare/v3.4.0...v3.5.0)

#### What's Changed

- Add new public key for known_hosts by
[@&#8203;cdb](https://togithub.com/cdb) in
[actions/checkout#1237

#### New Contributors

- [@&#8203;cdb](https://togithub.com/cdb) made their first contribution
in
[actions/checkout#1237

**Full Changelog**:
actions/checkout@v3.4.0...v3.5.0

###
[`v3.4.0`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v340)

[Compare
Source](https://togithub.com/actions/checkout/compare/v3.3.0...v3.4.0)

- [Upgrade codeql actions to
v2](https://togithub.com/actions/checkout/pull/1209)
- [Upgrade
dependencies](https://togithub.com/actions/checkout/pull/1210)
- [Upgrade
@&#8203;actions/io](https://togithub.com/actions/checkout/pull/1225)

</details>

<details>
<summary>github/codeql-action</summary>

###
[`v2.2.11`](https://togithub.com/github/codeql-action/compare/v2.2.10...v2.2.11)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.2.10...v2.2.11)

###
[`v2.2.10`](https://togithub.com/github/codeql-action/compare/v2.2.9...v2.2.10)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.2.9...v2.2.10)

</details>

<details>
<summary>sigstore/cosign-installer</summary>

###
[`v3.0.2`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.2)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.1...v3.0.2)

##### What's Changed

- add --yes to example workflow by
[@&#8203;sebhoss](https://togithub.com/sebhoss) in
[sigstore/cosign-installer#110
- Fix aarch64 action run by
[@&#8203;ananos](https://togithub.com/ananos) in
[sigstore/cosign-installer#113
- Bump actions/checkout from 3.3.0 to 3.4.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#115
- Bump actions/setup-go from 3.5.0 to 4.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#114
- Bump actions/checkout from 3.4.0 to 3.5.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#116
- default cosign to v2.0.1 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#117

##### New Contributors

- [@&#8203;sebhoss](https://togithub.com/sebhoss) made their first
contribution in
[sigstore/cosign-installer#110
- [@&#8203;ananos](https://togithub.com/ananos) made their first
contribution in
[sigstore/cosign-installer#113

**Full Changelog**:
sigstore/cosign-installer@v3...v3.0.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/slsa-framework/slsa-github-generator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zMS40IiwidXBkYXRlZEluVmVyIjoiMzUuMzEuNCJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Racer159 pushed a commit to defenseunicorns/zarf that referenced this pull request Dec 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[sigstore/cosign-installer](https://togithub.com/sigstore/cosign-installer)
| action | major | `v2.8.1` -> `v3.3.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>sigstore/cosign-installer (sigstore/cosign-installer)</summary>

###
[`v3.3.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.3.0)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.2.0...v3.3.0)

#### What's Changed

- Bump actions/setup-go from 4.1.0 to 5.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#152
- update action to use latest cosign v2.2.2 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#153

**Full Changelog**:
sigstore/cosign-installer@v3.2.0...v3.3.0

###
[`v3.2.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.2.0)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.2...v3.2.0)

**Note: This release comes with a fix for CVE-2023-46737 described in
this [Github Security
Advisory](https://togithub.com/sigstore/cosign/security/advisories/GHSA-vfp6-jrw2-99g9).
Please upgrade to this release ASAP**

see https://github.com/sigstore/cosign/releases/tag/v2.2.1

#### What's Changed

- Support the runner context of gitea act by
[@&#8203;josedev-union](https://togithub.com/josedev-union) in
[sigstore/cosign-installer#147
- bump cosign to v2.2.1 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#148
- test with latest go version by
[@&#8203;bobcallaway](https://togithub.com/bobcallaway) in
[sigstore/cosign-installer#150

#### New Contributors

- [@&#8203;josedev-union](https://togithub.com/josedev-union) made their
first contribution in
[sigstore/cosign-installer#147

**Full Changelog**:
sigstore/cosign-installer@v3...v3.2.0

###
[`v3.1.2`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.2)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.1...v3.1.2)

#### What's Changed

- Fix build and push step Readme missing id by
[@&#8203;hbenali](https://togithub.com/hbenali) in
[sigstore/cosign-installer#138
- bump cosign to v2.2.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#142

#### New Contributors

- [@&#8203;hbenali](https://togithub.com/hbenali) made their first
contribution in
[sigstore/cosign-installer#138

**Full Changelog**:
sigstore/cosign-installer@v3...v3.1.2

###
[`v3.1.1`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.1)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.0...v3.1.1)

#### What's Changed

- default cosign to v2.1.1 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#137

**Full Changelog**:
sigstore/cosign-installer@v3.1.0...v3.1.1

###
[`v3.1.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.0)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.5...v3.1.0)

#### What's Changed

- update job to use latest action release by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#130
- Update action example for keyless signing as xarg is not required by
[@&#8203;jbtrystram](https://togithub.com/jbtrystram) in
[sigstore/cosign-installer#132
- update examples by [@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#133
- bump cosign to default to release v2.1.0 and update docs by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#136

#### New Contributors

- [@&#8203;jbtrystram](https://togithub.com/jbtrystram) made their first
contribution in
[sigstore/cosign-installer#132

**Full Changelog**:
sigstore/cosign-installer@v3.0.5...v3.1.0

###
[`v3.0.5`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.5)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.4...v3.0.5)

#### What's Changed

- download cosign releases from GitHub rather than GCS by
[@&#8203;bobcallaway](https://togithub.com/bobcallaway) in
[sigstore/cosign-installer#126

**Full Changelog**:
sigstore/cosign-installer@v3.0.4...v3.0.5

###
[`v3.0.4`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.4)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.3...v3.0.4)

- Include fix for
[sigstore/cosign-installer#124
- changes download URL for `cosign` binary to github.com instead of GCS

###
[`v3.0.3`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.3)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.2...v3.0.3)

##### What's Changed

- bump to cosign v2.0.2 by
[@&#8203;bobcallaway](https://togithub.com/bobcallaway) in
[sigstore/cosign-installer#119
- changes download URL for `cosign` binary to github.com instead of GCS

**Full Changelog**:
sigstore/cosign-installer@v3.0.2...v3.0.3

###
[`v3.0.2`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.2)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.1...v3.0.2)

##### What's Changed

- add --yes to example workflow by
[@&#8203;sebhoss](https://togithub.com/sebhoss) in
[sigstore/cosign-installer#110
- Fix aarch64 action run by
[@&#8203;ananos](https://togithub.com/ananos) in
[sigstore/cosign-installer#113
- Bump actions/checkout from 3.3.0 to 3.4.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#115
- Bump actions/setup-go from 3.5.0 to 4.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#114
- Bump actions/checkout from 3.4.0 to 3.5.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[sigstore/cosign-installer#116
- default cosign to v2.0.1 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[sigstore/cosign-installer#117
- changes download URL for `cosign` binary to github.com instead of GCS

##### New Contributors

- [@&#8203;sebhoss](https://togithub.com/sebhoss) made their first
contribution in
[sigstore/cosign-installer#110
- [@&#8203;ananos](https://togithub.com/ananos) made their first
contribution in
[sigstore/cosign-installer#113

**Full Changelog**:
sigstore/cosign-installer@v3...v3.0.2

###
[`v3.0.1`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.1)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.0...v3.0.1)

##### What's Changed

- make cosign v2.0.0 default version by
[@&#8203;developer-guy](https://togithub.com/developer-guy) in
[sigstore/cosign-installer#109
- changes download URL for `cosign` binary to github.com instead of GCS

**Full Changelog**:
sigstore/cosign-installer@v3.0.0...v3.0.1

###
[`v3.0.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.0)

[Compare
Source](https://togithub.com/sigstore/cosign-installer/compare/v2.8.1...v3.0.0)

##### Breaking change

Cosign v2 has some breaking changes. Please check those:
https://blog.sigstore.dev/cosign-2-0-released/

##### What's Changed

- test: add logs when downloading the public keys by
[@&#8203;hectorj2f](https://togithub.com/hectorj2f) in
[sigstore/cosign-installer#106
- Add support to install v2 and any other cosign release candidate by
[@&#8203;hectorj2f](https://togithub.com/hectorj2f) in
[sigstore/cosign-installer#105
- v2.0.0 release by [@&#8203;sabre1041](https://togithub.com/sabre1041)
in
[sigstore/cosign-installer#108
- changes download URL for `cosign` binary to github.com instead of GCS

##### New Contributors

- [@&#8203;hectorj2f](https://togithub.com/hectorj2f) made their first
contribution in
[sigstore/cosign-installer#106
- [@&#8203;sabre1041](https://togithub.com/sabre1041) made their first
contribution in
[sigstore/cosign-installer#108

**Full Changelog**:
sigstore/cosign-installer@v2...v3.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3Ljg3LjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants