Skip to content

Commit

Permalink
Remove sign_blob_test.sh test (#3707)
Browse files Browse the repository at this point in the history
The bug that this test was meant to address[1] applies to a feature that
was removed from cosign[2]. The updates made to the script to allow for
the breaking changes actually make the test invalid, because while it
was once verifying the original artifact signature, the final
verification step is now actually verifying against the uploaded rekor
entry, so the original signature is inconsequential.

[1] #1673
[2] #2425

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
  • Loading branch information
cmurphy committed May 20, 2024
1 parent 2e65241 commit 645636e
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 126 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/github-oidc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,3 @@ jobs:
set -e
# Build and publish an image.
make sign-ci-keyless-containers
- name: Build and sign a blob
run: |
set -e
make sign-blob-experimental
4 changes: 0 additions & 4 deletions test/ci.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ sign-ci-containers: ko
.PHONY: sign-ci-keyless-containers
sign-ci-keyless-containers: ko
./scripts/sign-images-ci.sh

.PHONY: sign-blob-experimental
sign-blob-experimental:
./test/sign_blob_test.sh
85 changes: 0 additions & 85 deletions test/sign_blob_test.sh

This file was deleted.

10 changes: 0 additions & 10 deletions test/testdata/README.md

This file was deleted.

10 changes: 0 additions & 10 deletions test/testdata/test_blob_cert.pem

This file was deleted.

8 changes: 0 additions & 8 deletions test/testdata/test_blob_private_key

This file was deleted.

4 changes: 0 additions & 4 deletions test/testdata/test_blob_public_key

This file was deleted.

0 comments on commit 645636e

Please sign in to comment.