BREAKING: Remove non-GA APIs from sign-blob verification #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znewman01
reviewed
Nov 8, 2022
asraa
force-pushed
the
remove-experimental
branch
from
aae24b7
to
fd50b51
Compare
Signed-off-by: Asra Ali <asraa@google.com> remove code Signed-off-by: Asra Ali <asraa@google.com>
asraa
force-pushed
the
remove-experimental
branch
from
fd50b51
to
ebc281b
Compare
hectorj2f
approved these changes
Nov 8, 2022
cmurphy
added a commit
to cmurphy/cosign
that referenced
this pull request
May 20, 2024
The bug that this test was meant to address[1] applies to a feature that was removed from cosign[2]. The updates made to the script to allow for the breaking changes actually make the test invalid, because while it was once verifying the original artifact signature, the final verification step is now actually verifying against the uploaded rekor entry, so the original signature is inconsequential. [1] sigstore#1673 [2] sigstore#2425
cmurphy
added a commit
to cmurphy/cosign
that referenced
this pull request
May 20, 2024
The bug that this test was meant to address[1] applies to a feature that was removed from cosign[2]. The updates made to the script to allow for the breaking changes actually make the test invalid, because while it was once verifying the original artifact signature, the final verification step is now actually verifying against the uploaded rekor entry, so the original signature is inconsequential. [1] sigstore#1673 [2] sigstore#2425 Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
cmurphy
added a commit
to cmurphy/cosign
that referenced
this pull request
May 20, 2024
The bug that this test was meant to address[1] applies to a feature that was removed from cosign[2]. The updates made to the script to allow for the breaking changes actually make the test invalid, because while it was once verifying the original artifact signature, the final verification step is now actually verifying against the uploaded rekor entry, so the original signature is inconsequential. [1] sigstore#1673 [2] sigstore#2425 Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
haydentherapper
pushed a commit
that referenced
this pull request
May 20, 2024
The bug that this test was meant to address[1] applies to a feature that was removed from cosign[2]. The updates made to the script to allow for the breaking changes actually make the test invalid, because while it was once verifying the original artifact signature, the final verification step is now actually verifying against the uploaded rekor entry, so the original signature is inconsequential. [1] #1673 [2] #2425 Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Fixes #2419
Requires users to provide a bundle or a certificate and signature so that we can recreate the Rekor entry and not search by payload hash using the non-GA Rekor endpoint.
Summary
Release Note
--bundleOR both the--signatureand--certificate/--keyto theverify-blobcommand.Documentation