Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Alibaba Cloud Container Registry cred helper #2007

Closed
mozillazg opened this issue Jun 18, 2022 · 0 comments · Fixed by #2008
Closed

feat: integrate Alibaba Cloud Container Registry cred helper #2007

mozillazg opened this issue Jun 18, 2022 · 0 comments · Fixed by #2008
Labels
enhancement New feature or request

Comments

@mozillazg
Copy link
Contributor

Description

Integrate a new keychain (via docker-credential-acr-helper) to support Alibaba Cloud Container Registry.

@mozillazg mozillazg added the enhancement New feature or request label Jun 18, 2022
mozillazg added a commit to mozillazg/cosign that referenced this issue Jun 18, 2022
Resolves: sigstore#2007

Signed-off-by: mozillazg <mozillazg101@gmail.com>
mozillazg added a commit to mozillazg/cosign that referenced this issue Jun 18, 2022
Resolves: sigstore#2007

Signed-off-by: mozillazg <mozillazg101@gmail.com>
mozillazg added a commit to mozillazg/cosign that referenced this issue Jun 18, 2022
Integrate a new keychain to support Alibaba Cloud Container Registry
when run with the `--k8s-keychain` flag.

Resolves: sigstore#2007

Signed-off-by: mozillazg <mozillazg101@gmail.com>
dlorenc pushed a commit that referenced this issue Aug 29, 2022
* feat: integrate Alibaba Cloud Container Registry cred helper

Integrate a new keychain to support Alibaba Cloud Container Registry
when run with the `--k8s-keychain` flag.

Resolves: #2007

Signed-off-by: mozillazg <mozillazg101@gmail.com>

* update codegen

Signed-off-by: mozillazg <mozillazg101@gmail.com>

* upgrade dependencies

Signed-off-by: mozillazg <mozillazg101@gmail.com>

* Use `io.Discard` instead of `ioutil.Discard`

Signed-off-by: mozillazg <mozillazg101@gmail.com>

Signed-off-by: mozillazg <mozillazg101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant