return error when rekor pub cannot be retrieved, fix file path construction #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction Signed-off-by: Jake Sanders <jsand@google.com>
mattmoor
approved these changes
Dec 7, 2021
asraa
reviewed
Dec 7, 2021
| if err := tuf.GetTarget(ctx, rekorTargetStr, &buf); err != nil { | ||
| panic("error retrieving rekor public key") | ||
| return nil, err |
There was a problem hiding this comment.
this might be a local cache being old/invalid -- maybe we can say "please remove local cache" (this should be a const str in the tuf code DefaultCache or something)
There was a problem hiding this comment.
PRs welcome :D
If there's a place where we can definitively say "this local cache is old/invalid and we can't fix it," lets do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (probably) doesn't fix the error being seen by @cpanato during verification on windows, but it does surface the error and take care of some potential root causes