create KeylessSigner #1189
Merged
create KeylessSigner #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Sanders <jsand@google.com>
mattmoor
reviewed
Dec 13, 2021
| } | ||
| s, err := signature.LoadECDSASignerVerifier(priv, crypto.SHA256) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
We should consistently wrap errors, I think.
mattmoor
reviewed
Dec 13, 2021
Comment on lines
64
to
69
| // NewSigner generates a new private signing key and returns a `cosign.Signer` which creates signatures with it. | ||
| func NewSigner() (icosign.Signer, error) { | ||
| priv, err := cosign.GeneratePrivateKey() | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "generating cert") | ||
| } |
There was a problem hiding this comment.
Generally when we say "keyless" we mean the full Fulcio flow with the ephemeral certificate chained into the root CA (and optionally logged to Rekor). Perhaps to avoid creating confusion over the term "keyless" (since it is only part) we should call this "ephemeral"?
Signed-off-by: Jake Sanders <jsand@google.com>
mattmoor
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
#844
Release Note