feat: implement cosign download attestation #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
|
This makes sense to me - at first I was thinking it could be dangerous to download these without verification but the attestation is pretty clearly a signed object that requires unpacking/verification before use. I'm +1 here, but want to let this sit for a bit to see if others agree. |
dlorenc
approved these changes
Dec 17, 2021
|
OK, seems good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides support for downloading in-toto attestation(s) from a supplied container image.
Release Note
cosign download attestation <IMAGE>