Fix incorrect error check when verifying SCT #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
Failing CI test seems unrelated, can someone kick it off again? |
dekkagaijin
approved these changes
Feb 8, 2022
|
I have a fix for the ci here: #1415 |
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #1396, this incorrectly checked err instead
of verifySctErr. This resulted in no error being printed
when SCT validation failed. Verified this is working
correctly now with local testing.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note