Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert release cosigned to also generate yaml artifact. #1453

Merged
merged 1 commit into from Feb 15, 2022

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Feb 13, 2022

Summary

After advise from @cpanato , updated the existing cloud build to generate a yaml artifact for the cosigned webhook instead of the standalone github action. This ensure that the image is built the same way as other artifacts.

This makes #1436 obsolete.

Ticket Link

Fixes

#1414

Release Note

NONE

Signed-off-by: Kenny Leung kleung@chainguard.dev

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
Copy link
Contributor Author

k4leung4 commented Feb 14, 2022

@cpanato one thing I'm not sure is whether all the artifacts listed in the cloudbuild.yaml will be included in the release or is there another step to it. can you please let me know if it is the case or not. thank you.

@cpanato
Copy link
Member

cpanato commented Feb 15, 2022

sorry for the delay, missed this notification

Copy link
Member

@cpanato cpanato left a comment

I will run a rehearsal soon in my fork
thanks for working and improving this

and we need this only for cosigned?

@k4leung4
Copy link
Contributor Author

k4leung4 commented Feb 15, 2022

I only added this for cosigned and not cosign or sget as there are no yamls associated with those.
we will want this for fulcio and rekor at some point, but no one has asked for them just yet.
i will work on that in the near future.

I will run a rehearsal soon in my fork thanks for working and improving this

and we need this only for cosigned?

@dlorenc dlorenc merged commit 6a34942 into sigstore:main Feb 15, 2022
21 checks passed
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 15, 2022
cpanato pushed a commit to cpanato/cosign that referenced this issue Feb 18, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
cpanato pushed a commit to cpanato/cosign that referenced this issue Feb 18, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato added a commit that referenced this issue Feb 18, 2022
* update cross-build to use go 1.17.7 (#1446)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* update cross-build to use go 1.17.7 (#1446)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* convert release cosigned to also generate yaml artifact. (#1453)

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* Double goreleaser timeout (#1472)

Fixes (hopefully) #1471

Signed-off-by: Zachary Newman <z@znewman.net>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* increase timeout for goreleaser snapshot (#1473)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* refactor release cloudbuild job (#1476)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

Co-authored-by: Kenny Leung <k4leung4@gmail.com>
Co-authored-by: Zack Newman <z@znewman.net>
@k4leung4 k4leung4 deleted the build-yaml branch Mar 8, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this issue May 6, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants