-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor release cloudbuild job #1476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
force-pushed
the
update-release2
branch
from
February 17, 2022 15:31
5e7051f
to
9507e79
Compare
k4leung4
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the issue I introduced.
you did not introduce any issue 🌮 🎉 |
cpanato
force-pushed
the
update-release2
branch
from
February 17, 2022 16:03
9507e79
to
2a1d4ba
Compare
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
force-pushed
the
update-release2
branch
from
February 17, 2022 16:08
7163d11
to
14daaf4
Compare
dlorenc
approved these changes
Feb 17, 2022
cpanato
added a commit
to cpanato/cosign
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
added a commit
to cpanato/cosign
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
added a commit
that referenced
this pull request
Feb 18, 2022
* update cross-build to use go 1.17.7 (#1446) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * update cross-build to use go 1.17.7 (#1446) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * convert release cosigned to also generate yaml artifact. (#1453) Signed-off-by: Kenny Leung <kleung@chainguard.dev> Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Double goreleaser timeout (#1472) Fixes (hopefully) #1471 Signed-off-by: Zachary Newman <z@znewman.net> Signed-off-by: Carlos Panato <ctadeu@gmail.com> * increase timeout for goreleaser snapshot (#1473) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * refactor release cloudbuild job (#1476) Signed-off-by: Carlos Panato <ctadeu@gmail.com> Co-authored-by: Kenny Leung <k4leung4@gmail.com> Co-authored-by: Zack Newman <z@znewman.net>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the PR #1453 we added the YAML for cosigned, but that is not pushed to the GitHub release because it out of scope for Goreleaser and run outside
This PR joins the image generation using
ko
inside the Goreleaser job and runs as before hook and in the end, it pushed the YAML for cosigned to the release.Rehersal: https://github.com/cpanato/cosign/releases/tag/v99.99.01
image:
/assign @dlorenc @k4leung4
also if this is running as part of ci validate job it ignore the ko build
Ticket Link
n/a
Release Note