Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add correct layer media type to cosign attach attestation #1503

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Feb 22, 2022

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

Summary

Closes #1494.

Updates cosign attach attestation command to use the media layer type described in the attestation specification.

Ticket Link

Fixes #1494

Release Note

update cosign attach attestation to use application/vnd.dsse.envelope.v1+json

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs
Copy link
Contributor Author

spiffcs commented Feb 22, 2022

I'll take a look at the updates for this e2e test.

@dlorenc
Copy link
Member

dlorenc commented Feb 22, 2022

I'll take a look at the updates for this e2e test.

I think you're good, the e2e failure was an unrelated flake.

@dlorenc dlorenc merged commit ec79daf into sigstore:main Feb 22, 2022
hatmarch pushed a commit to hatmarch/cosign that referenced this pull request Apr 19, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update media type for attach attestation command
2 participants