Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra label and change the latest tag to unstable for non tagged releases #1637

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 21, 2022

Summary

  • adding extra label to the container to be show in the artifact hub another location that users can consume the image
  • also rename the tag that we push in CI to be unstable instead of latest, we will use the latest tag when releasing a new version (xref: push latest tag when building a release #1636)

Ticket Link

n/a

Release Note

NONE

@cpanato cpanato requested a review from dlorenc March 21, 2022 09:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #1637 (26215b6) into main (f9fe6a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   27.97%   27.97%           
=======================================
  Files         137      137           
  Lines        7820     7820           
=======================================
  Hits         2188     2188           
  Misses       5403     5403           
  Partials      229      229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fe6a4...26215b6. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: cpanato <ctadeu@gmail.com>
@dlorenc dlorenc merged commit f48f00b into sigstore:main Mar 21, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 21, 2022
@cpanato cpanato deleted the updates branch March 21, 2022 11:47
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
…releases (sigstore#1637)

* add alternative location for cosign to be show in the artifcat hub

Signed-off-by: cpanato <ctadeu@gmail.com>

* use unstable tag instead of latest (latest will be used when pushing a tag)

Signed-off-by: cpanato <ctadeu@gmail.com>

* fix wrong quote

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants